Add support for Divider in menus
#318
Conversation
also menus were rendered backwards apparently. this fixes that (stackotter#317)
this was shockingly trivial, if the docs are to be believed
…is dependent on where the menu appears from)
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
I'm on mobile, but everything looks good other than the two things I've commented on. I'll test the changes locally when I get the time.
|
The dividers don't show up in menu button popovers under Gtk3Backend (even though they do show up in application menus). It's probably a CSS issue, or a limitation of Gtk 3. I don't think that it's worth pursuing that issue in this PR because Gtk3Backend is a bit of a legacy backend. I've tested with every other backend and they seem to work well. Happy to merge once my last comment has been resolved. |
|
Okay, the CI's failing for GTK with "cannot find 'model' in scope". I'll wait until tomorrow (or perhaps later today) to fix this, my laptop's packed up right now and I don't want to dig it out. |
2 participants
Implemented in all backends. AppKitBackend and WinUIBackend were both trivial two-liners, Gtk[3]Backend required a bit of work but nothing too bad, and UIKitBackend was also pretty simple.